Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(taxes_and_fees): update a logic of calculation taxes and fees #41

Merged
merged 4 commits into from
Oct 29, 2021
Merged

feat(taxes_and_fees): update a logic of calculation taxes and fees #41

merged 4 commits into from
Oct 29, 2021

Conversation

reb2020
Copy link
Contributor

@reb2020 reb2020 commented Oct 29, 2021 •
edited
Loading

Added strummer matcher

Sonyque
Sonyque reviewed Oct 29, 2021
View reviewed changes
Copy link

@Sonyque Sonyque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the test coverage for the validator?

@reb2020
Copy link
Contributor Author

reb2020 commented Oct 29, 2021

added

@reb2020 reb2020 merged commit 8cb562b into master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sonyque Sonyque Sonyque approved these changes

@nguyenchr nguyenchr Awaiting requested review from nguyenchr

@jvke jvke Awaiting requested review from jvke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reb2020 @Sonyque